Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize compute #270

Merged
merged 73 commits into from
Feb 29, 2024
Merged

Initialize compute #270

merged 73 commits into from
Feb 29, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented Feb 19, 2024 •
edited
Loading

Fixes #230 .

Changes proposed in this PR:

  • created initializeCompute
  • add test

@mariacarmina mariacarmina self-assigned this Feb 19, 2024
@mariacarmina mariacarmina marked this pull request as ready for review February 19, 2024 17:20
bogdanfazakas
bogdanfazakas reviewed Feb 21, 2024
View reviewed changes
src/@types/commands.ts Outdated Show resolved Hide resolved
src/components/core/compute.ts Outdated Show resolved Hide resolved
alexcos20
alexcos20 requested changes Feb 26, 2024
View reviewed changes
src/@types/commands.ts Outdated Show resolved Hide resolved
src/components/core/compute.ts Outdated Show resolved Hide resolved
mariacarmina
mariacarmina commented Feb 26, 2024
View reviewed changes
Copy link
Member Author

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also need to expose initializeCompute via http.

@mariacarmina
Copy link
Member Author

Still need to test via ocean-cli, but if you have other suggestions regarding the code, it will be open for review.

@mariacarmina mariacarmina marked this pull request as ready for review February 28, 2024 20:38
alexcos20
alexcos20 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bogdanfazakas
bogdanfazakas approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides some small remarks looks good

src/@types/commands.ts Outdated Show resolved Hide resolved
src/components/httpRoutes/compute.ts Show resolved Hide resolved
@mariacarmina mariacarmina merged commit 3a7c180 into develop Feb 29, 2024
6 checks passed
@mariacarmina mariacarmina deleted the initialize-compute branch February 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@alexcos20 alexcos20 alexcos20 approved these changes

@an7e an7e Awaiting requested review from an7e

@paulo-ocean paulo-ocean Awaiting requested review from paulo-ocean paulo-ocean is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

Assignees

@mariacarmina mariacarmina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mariacarmina @alexcos20 @bogdanfazakas @jamiehewitt15 @paulo-ocean